Hey Joren! Yeah i have had a look at this wiki page : https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerrit
loooong back(when i started hacking on LO codebase) and had played around with it for a time being .But seriously and frankly speaking i am more comfortable on this,but i am sure i will try to work on gerrit(as there is always a scope to learn something new..and this has been a wonderful leaning experience since then) now so as to ease the work. Hope this finds you in good health. Regards, Janit On Wed, Apr 17, 2013 at 12:08 AM, JorenDC <joren.libreoff...@telenet.be>wrote: > Hi Janit, > > I see your patches keeps passing by. Sending your patch by email is not > wrong, but we have another handy tool to review/comment/... patches -> > Gerrit. > > Please have a look at > https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerritso > you can send them that way. I think that's a lot easier for developers > to review and leave comments. > > Just my 0,02€ (please be aware of the currency exchange ;-) ) > > Kind regards, > Joren > > Op 16-04-13 20:30, Janit Anjaria schreef: > > Hey! > > I am hereby attaching my patch for fdo #62096 : > > https://bugs.freedesktop.org/show_bug.cgi?id=62096 > > Any suggestions would be great to be implemented. > > Regards, > Janit > > On Tue, Apr 16, 2013 at 11:52 PM, Janit Anjaria <jani...@gmail.com> wrote: > >> Hey Stephan! >> I think that was due to hurry(the things for "!=" things)...and yeah i >> dont know ,i overlooked the build and hence i suppose the thing you just >> mentioned about child_process.cxx is one of those rotten tests. >> >> And yes,ill surely look into the matter with identation(i generally do >> take care of it,but because of a lil hurry as i am also working on the >> project -i had mailed on the list simultaneously ...so swamped with too >> much of code ! :P ) >> >> Hope this finds you in good health. >> >> Regards, >> Janit >> >> >> On Tue, Apr 16, 2013 at 6:30 PM, Stephan Bergmann <sberg...@redhat.com>wrote: >> >>> On 04/15/2013 03:19 PM, Janit Anjaria wrote: >>> >>>> I am hereby attaching my patch for fdo #62096 : >>>> >>>> https://bugs.freedesktop.org/show_bug.cgi?id=62096 >>>> >>>> Any suggestions would be great to be implemented. >>>> >>> >>> First, note that >>> >>> s.compareTo(t) != 0 >>> >>> is /not/ the same as >>> >>> s == t >>> >>> Second, did you build and test your change? It looks like >>> sal/qa/rtl/process/child_process.cxx is one of those rotting tests that is >>> not built nor executed, not even with a top-level "make check". >>> >>> Also, please take care not to mess up the indentation of lines, making >>> the "if" indented only three instead of four spaces. >>> >>> Stephan >>> >> >> > > > _______________________________________________ > LibreOffice mailing > listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice > > > > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
