On Friday, August 03, 2012 12:52:47 AM Thiago Marcos P. Santos wrote: > On Thu, 2012-08-02 at 16:26 -0400, Paul Moore wrote: > > First off, *please* no more HTML mail. I dislike having to remove the > > markup and reformat your email in my reply. It also has a tendency to > > make me cranky, and I'm less likely to apply patches when I'm cranky. > > GMail web interface was forcing me to. I bet you kernel developers are > using mutt. If people stop using HTML, who will pay me to work on > WebKit? /me runs
Heh :) For the record, GMail doesn't force you to send HTML mail, see the link below: "If you decide you'd like to write a message in plain text format, just click Plain text along the top of the compose window." * https://support.google.com/mail/bin/answer.py?hl=en&answer=8260 > > Anyway, back to the substance of your email ... Thanks for the example. > > In this particular case I think I would rather see us implement a > > structure which could be used to specify the arg/op/value combinations and > > pass a pointer to an array in the new rule_add APIs. The existing va_list > > based approach was designed to make it easier for developers by reducing > > the amount of work they had to do beyond just the function call, and while > > I think it succeeds for the most part, there are a lot of drawbacks around > > types and just safety in general. A structure based API removes many of > > these problems, and in your example shouldn't add too much burden to the > > developer. > > > > Thoughts? > > It's a solution. But I also want to reduce the amount of work of people > using my class and my goal was to make the API resembling as much as > possible libseccomp ... I was thinking you could keep the variable argument API in your class, just build the structure in SeccompFilters::addRule() function. Would that not work? -- paul moore security and virtualization @ redhat ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libseccomp-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libseccomp-discuss
