On 03/26/2013 11:54 PM, Paul Moore wrote:
> On Thursday, March 21, 2013 08:51:34 PM [email protected] wrote:
>> From: Vitaly _Vi Shukela<[email protected]>
> First off, a general comment, can I have your permission to add your sign-off
> to these patches?
Yes. Should I just press "Sign off" button by default when submitting
code to public open source projects?
> Also, I'll go ahead and fix them up but in the future
> submissions please be more mindful of whitespace, alignment, and the 80
> character width limit.
>
Strange. This time I explicitly checked the whitespace (there were many
errors, I used vim to make tabs vs spaces look like the rest of the
code, than I used Git to fix up "trailing whitespace" on lines and only
after that I sent). I also remember looking at 80-character line and
fixing overrun lines...
Is there some /usr/bin/indent call to automatically make all whitespace
just right for this project?
> The python version of the test is also missing.
> However, we still need a 22-*.py test so we don't break the
regression test.
I though about it, but I considered this new API only touches C API.
Should the missing test be a dummy? It's no use to have two exactly the
same tests.
>> { struct scmp_arg_cmp filters[] = ...; ... }
> Hmmm, I'm not really a fan of this approach using braces to create a
new scope.
Do you know a better method? This:
1. Allows us to use the same name "filters" for all cases;
2. Explicitly specifies that "filters" is only used here, not somewhere
below;
3. Tells no-more-needed array not to linger in stack (if compiler not
optimizing it);
P.S.
There is "masked equality" comparator.
I tried (naively) to add "masked inequality", but failed. Is it tricky
to do by design?
Do you consider making comparators more powerful in future?
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
libseccomp-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libseccomp-discuss
