On Sunday 06 of December 2009 08:23:29 Peter Stuge wrote:
>     Fix padding in ssh-dss signature blob encoding
>
>     DSA signatures consist of two 160-bit integers called r and s. In
> ssh-dss signature blobs r and s are stored directly after each other in
> binary representation, making up a 320-bit (40 byte) string. (See RFC4253
> p14.)
>
>     The crypto wrappers in libssh2 would either pack r and s incorrectly,
> or fail, when at least one integer was small enough to be stored in 19
> bytes or less.
>
>     The patch ensures that r and s are always stored as two 160 bit
> numbers.

Really nice catch!

My investigation had never reached beyond the common part of DSA 
implementation. Who would expect two bugs with exactly same behavior
in two completely independent implementations? :-)

For now I can confirm the fix for OpenSSL part indeed solves the problem.

Thanks for the fix!

Kamil
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to