Hi,

Leif Salomonsson wrote:
> Only the HAVE_IOCTLSOCKET_CASE thingy left..
> Waiting for your reply on my reasoning there. 

The patch needs more work. Here are some comments.


> diff -u libssh2-1.4.2_orig/src/agent.c libssh2-1.4.2/src/agent.c
> --- libssh2-1.4.2_orig/src/agent.c    Mon Mar  5 20:04:56 2012
> +++ libssh2-1.4.2/src/agent.c Thu Aug  2 10:32:49 2012
> @@ -122,7 +122,7 @@
>  };
>  
>  struct agent_ops {
> -    agent_connect_func connect;
> +    agent_connect_func _connect_;

Are you saying that on this platform you have a C preprocessor
#defines for connect, send, recv, and crypt, which thus are stolen
from the global namespace? I think that is one insanely broken platform!

>:(

If this is indeed the case, and if we actually do want to support
such stupidity, then please at the very least use *sane* names
instead of adding horrible underscores.


> +++ libssh2-1.4.2/src/transport.c     Tue Jul 31 12:52:44 2012
> @@ -139,7 +139,7 @@
>      assert((len % blocksize) == 0);
>  
>      while (len >= blocksize) {
> -        if (session->remote.crypt->crypt(session, source,
> +        if (session->remote.crypt->_crypt_(session, source,

Wouldn't you have to change the session->remote.crypt name as well?


> @@ -167,7 +167,7 @@
>      unsigned char macbuf[MAX_MACSIZE];
>      struct transportpacket *p = &session->packet;
>      int rc;
> -
> +    

Please never make whitespace changes at the same time as other
changes.


//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to