On Monday, October 22, 2012 22:05:27 Peter Stuge wrote: > Kamil Dudka wrote: > > > > I think this is a waste of time. > > > > I am not forcing anybody to work on this. The time I spent on writing > > the patch was sponsored by my employer, so it was not a big waste really. > > Waste for the employer IMO. > > > We are trying to introduce an easy way to test new releases of > > libssh2 independently of the libraries and applications that use it. > > This is a great idea! > > > Running the set of examples distributed with libssh2 seemed like a > > reasonable step to start with. > > This not so much. The examples are, third time, intended to > demonstrate *library usage*. They are specifically not test cases. > > I would very much welcome test cases, which use the library, and not > the examples.
I agree, we need test cases. Still, the test cases can be based on the examples. If we need to test sftp, scp, tcp/ip forwarding, etc., we can just run the corresponding examples in a defined way and compare their output with the expected one. Otherwise we would have to duplicate the code exercising libssh2 and maintain it at two places. > The exapmles can be improved to be more readable, so that they better > serve their function of demonstrating library usage, but please stop > mistaking them for test cases sooner rather than later. I admit that my patch does not bring any major improvement from user's point of view, but I do not think it anyhow breaks the original purpose of those examples. Kamil _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
