On Mon, 22 Oct 2012, Kamil Dudka wrote:

I admit that my patch does not bring any major improvement from user's point of view, but I do not think it anyhow breaks the original purpose of those examples.

I agree. I don't think the patch harms anything but actually makes the situation slightly better.

I'm not entirely sure however that basing tests on the example code is a good idea, but I also feel that the one who's doing the job right now gets to do a fair bit of deciding. We _can_ after all clone the examples into separate test cases at a later point (instead of doing it immediately now) in case we end up needing that.


--

 / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to