Hi, I do not think we have strict rules for that. Generally in cases, where the comment was obvious in what needs to be done and it was obviously addressed, its ok to resolve the thread (reviewer will likely double-check, but its easier for him to see it resolved than double-checking and resolving all of the simple notes).
In cases where the suggestion was not completely clear and there some some clarification and discussion going on, its better to wait some more time for the reviewer if they are ok with the state or not. For me not knowing much about windows (anymore), I am ok with the current state. The only suggestion would be to squash the fixup commit to the first one and try to clarify the commit message a bit. Something like following should do: > session: add err messages for most common WSA error codes And one more thing. From what I see, this looks like your first contribution to libssh. I did not see your mail in the contributors repo so if you did not send the DCO yet, please do (if you did, I will just need to nudge Andreas to update the repo): https://gitlab.com/libssh/libssh-mirror/-/blob/master/CONTRIBUTING.md?ref_type=heads#how-to-sign-your-work Thanks, Jakub On Sat, Jul 26, 2025 at 11:18 PM <g4-l...@tonarchiv.ch> wrote: > Now it's stuck because of open threads... > > I'm new to gitlab. I could close the threads myself, at least there's a > button. But I think the "netiquette" is to ask you to review it ...? > > Cheers > Till > > July 25, 2025 3:06 PM, g4-l...@tonarchiv.ch wrote: > > Hi Jakub > > It's in the pipeline... > > Cheers > Till > > July 25, 2025 9:28 AM, "Jakub Jelen" <jje...@redhat.com > <jje...@redhat.com?to=%22jakub%20jelen%22%20%3cjje...@redhat.com%3E>> > wrote: > > Hi, I am not a windows expert so I do not know if there is a better way to > do that. But if it is helpful for you, it should be helpful for more of > libssh users or developers so we would be happy to accept this as a MR on > gitlab. > Thanks, > Jakub > On Fri, Jul 25, 2025 at 1:13 AM <g4-l...@tonarchiv.ch> wrote: > > With my cross compiled version for Windows I use this patch to get more > meaningful error messages from winsock (attached), > > strerror_s() doesn't know WSA error numbers. One would actually need > FormatMessage() for this purpose. > > Cheers > Till > > > > > > > > > >
