Hi Jakub July 28, 2025 1:37 PM, "Jakub Jelen" <jje...@redhat.com (mailto:jje...@redhat.com?to=%22Jakub%20Jelen%22%20<jje...@redhat.com>)> wrote: Hi, I do not think we have strict rules for that. Generally in cases, where the comment was obvious in what needs to be done and it was obviously addressed, its ok to resolve the thread (reviewer will likely double-check, but its easier for him to see it resolved than double-checking and resolving all of the simple notes).
In cases where the suggestion was not completely clear and there some some clarification and discussion going on, its better to wait some more time for the reviewer if they are ok with the state or not. Ok I closed the obvious one as resolved. For me not knowing much about windows (anymore), I am ok with the current state. The only suggestion would be to squash the fixup commit to the first one and try to clarify the commit message a bit. Something like following should do: > session: add err messages for most common WSA error codes Maybe you can give me some hint with this... I'm using git for a while, but this is my first MR. What do I do with my local branch to make it one commit (instead of two)? I rebased a few times and force-pushed... So this should not show up in the log... BTW I also run clang-format on the whole session.c so there were two format only changes that have nothing to do with the MR. And one more thing. From what I see, this looks like your first contribution to libssh. I did not see your mail in the contributors repo so if you did not send the DCO yet, please do (if you did, I will just need to nudge Andreas to update the repo): https://gitlab.com/libssh/libssh-mirror/-/blob/master/CONTRIBUTING.md?ref_type=heads#how-to-sign-your-work (https://gitlab.com/libssh/libssh-mirror/-/blob/master/CONTRIBUTING.md?ref_type=heads#how-to-sign-your-work) It's been a while. Like 7 years maybe? I sent a few patches for the server API... There wasn't Gitlab yet and I sent patches per mail. I'm not sure what mail address I was using though. Cheers Till
