* Gary V. Vaughan wrote on Mon, Aug 22, 2005 at 11:28:25PM CEST: > > Please compare your tree with my distcheck generated tarball from: > http://tkd.kicks-ass.net/dist/libtool-2.1a.tar.gz > > >I don't see any code generating this. > *snip* > > ltdl.m4: > ... > # LTDL_INIT([DIRECTORY]) > # ---------------------- > # Perform all the checks necessary for compilation of the ltdl objects > # -- including compiler checks and header checks. > AC_DEFUN([LTDL_INIT], > [m4_if([$#], 1, [m4_divert_push([DEFAULTS])dnl > # libltdl will be built in the named DIRECTORY, relative to > $top_builddir. > lt_ltdl_dir='$1' *snip* > > >What makes me wonder is how you cannot reproduce this.. are both of > >those variables empty for you? If so, why (not having dlopen.la on > >GNU/Linux would be a bug)? > > Maybe cvs diff is not generating a complete patch, or it is not applying > to your tree correctly because of the file moves?
Bingo. cvs diff does not walk into libltdl/m4, because libltdl/CVS/Entries does not contain that subdir. So your patch never showed the ltdl.m4 changes: | -# LTDL_INIT | -# --------- | +# LTDL_INIT([DIRECTORY]) | +# ---------------------- | # Perform all the checks necessary for compilation of the ltdl objects | # -- including compiler checks and header checks. | AC_DEFUN([LTDL_INIT], | -[AC_REQUIRE([AC_PROG_CC])dnl | +[m4_if([$#], 1, [m4_divert_push([DEFAULTS])dnl | +# libltdl will be built in the named DIRECTORY, relative to $top_builddir. | +lt_ltdl_dir='$1' | +m4_divert_pop([DEFAULTS])])dnl | + | +AC_REQUIRE([AC_PROG_CC])dnl *snip* I believe they are ok, can't test them ATM. Please go ahead and commit the patch in the two steps, if you like. For CVS you will probably have to remove and add the moved subdirs. Out of curiosity, I'd still like to know what the m4_divert_push is for here, could you explain to me? Don't the AC_REQUIRE's have to go before anything else in a macro? Thanks, Ralf
