On Sun, 24 Jun 2007, Ralf Wildenhues wrote:
If we need to use pointers to void for hiding in external headers, then so be it. But most of the time I don't see why this: struct lt_foo; /* declaration only, no definition */ typedef struct lt_foo *lt_foo_handle; int lt_foofunc (lt_foo_handle);
I definitely agree that the approach you describe is much better than an approach which requires casts from a pointer of void type. In C, casts lead to suspicion of the code since they eliminate the compiler's ability to detect and notify of problems.
These hunks are all superfluous, except of course the one functional change to the tryall_dlopen call, for which one must look closely to not overlook it. Please separate functional changes from cleanup changes in patch postings, that would make the former be much more easily spottable.
I definitely agree here too. Bob ====================================== Bob Friesenhahn [EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
