* Peter Rosin wrote on Sun, Aug 10, 2008 at 12:05:39AM CEST: >> Ralf Wildenhues skrev: >>> (you know how to push changes to a branch?) >> >> I'm sure I can read up on that in a number of git resources on the >> web. Is there anything I should be aware of that is special for >> libtool?
Not really; I suppose I should adjust HACKING to our git usage a bit (coming up in a separate message). >>> I haven't yet decided for myself whether I would like to see this >>> split-up in the other test failures too, but I would definitely like >>> to see it in export.at. Maybe in stresstest.at too, but not in the >>> old-style testsuite. I'm open to suggestions here though. >> >> dllimport is only needed on variables, functions work just fine to >> import on MSVC as well (at least I think so). So the naming >> LIBA_SCOPE and LIBA_SCOPE_VAR is perhaps a bit misleading since they >> are both used for variables. Also, in what cases do you need the >> dllimport for gcc? I don't seen any pattern. Sure, const seems to >> be involved, but if not dllimporting variables doesn't always work, >> isn't it a support nightmare to only recommend dllimport when it's >> desperately needed? > > I was confused by const char v8[] which is apparently dll-auto-imported > by gcc even if it's const. Oh well; if somebody digs out the auto-import semantics from the list archives/manuals, feel free to add a note to export.at so that the next person won't be confused again. (Extra score for putting it in the new w32 chapter. ;-) > Oh well, I thought a bit about it and you can view it as if LIBA_SCOPE_VAR > is used for variables that truely are variable (i.e. non-const). Exactly. > Please let me know if I got anything wrong in the push. Looks just fine, thanks. Cheers, Ralf