* Paolo Bonzini wrote on Sun, Aug 15, 2010 at 06:57:18PM CEST:
> Here are the improvements you suggested.  I'll send a patch for
> sed_make_literal_regex soon.
> 
> Ok?

Yes, with the nit addressed.  Thanks!
Ralf

> * libltdl/config/ltmain.m4sh (func_mode_finish): Change sysroot_regex
> and sysroot_cmd delimiter from pipe to slash.  Wrap the entire for
> loop with "if $opt_dry_run...fi" and print an explanatory message
> for the --dry-run case.

> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -1419,24 +1419,27 @@ func_mode_finish ()
>      done
>  
>      if test -n "$libs"; then
> -      tmpdir=`func_mktempdir`
>        if test -n "$lt_sysroot"; then
> -        sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*|]/\\\\&/g'`
> -        sysroot_cmd="s|\([ ']\)$sysroot_regex|\1|g;"
> +        sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*/]/\\\\&/g'`

You need a \ before the / inside the bracket expression:
  +        sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*\/]/\\\\&/g'`

'info Autoconf --index sed' explains why.

> +        sysroot_cmd="s/\([ ']\)$sysroot_regex/\1/g;"

Reply via email to