* Charles Wilson wrote on Mon, Aug 16, 2010 at 10:27:46PM CEST:
> Taking all of this together, I wonder if a good approach might be the
> following: libltdl replaces the '=' with the value of the environment
> variable LIBLTDL_SYSROOT.  So usually -- with this variable empty -- '='
> is just stripped out, which would be typical on the $host system. This
> would open up possible exploits -- but if you --finish your .la files,
> then there ARE no '=' markers to replace, so you'd be safe.

Sounds good.  Make that LTDL_SYSROOT please, though, similar to the
other variables it uses.

> >> (*) I don't have fortran installed. It's not clear why the fc and f77
> >> tests aren't shown as 'skipped'.
> > 
> > Can you rerun only those tests with
> >   make check-local TESTSUITEFLAGS='-k FC -k F77 -v -d -x'
> 
> Err, sure, but the NEW testsuite did report the correct "skippage":

> It's just that the OLD testsuite didn't even mention the F77/FC tests:

Oh, sorry for the mis-parse.  Can you run
  VERBOSE=yes $srcdir/tests/fcdemo-conf.test; echo $?

and post the output of that?  VERBOSE=debug is even more informative, if
that is necessary.  Thanks.

> >> -      if $opt_dry_run; then
> >> +      if ${opt_dry_run-false}; then
> > 
> > I don't get it.  opt_dry_run is initialized unconditionally early in the
> > libtool script, from general.m4sh, and never unset.  What's the reason
> > for ${...-default}?
> 
> I was just copying the pattern I saw elsewhere. If it's safe to proceed
> without the default, then that's fine too.

Yep it should be.

Cheers,
Ralf

Reply via email to