Hi Charles, * Charles Wilson wrote on Fri, Jan 07, 2011 at 05:55:50PM CET: > On 1/7/2011 3:02 AM, Peter Rosin wrote: > > Den 2011-01-06 21:29 skrev Ralf Wildenhues: > >> * Peter Rosin wrote on Tue, Jan 04, 2011 at 05:44:58PM CET: > >>> Before I tie up the lose ends with this patch, I wonder if Ralf (or > >>> someone > >>> else) could tell me if I should also fix the other assignments of > >>> old_archive_cmds -- such as in the below snippet -- or is that completely > >>> irrelevant? > >> > >> I wouldn't change them without being sure that the changes are > >> necessary. > > > > Well, they are necessary, but in cases which are, errhm, convoluted... > > > > Such as: win32-hosted cross-tools (I mean native win32 here, not > > dependent on Cygwin or MSYS) for targeting irix (or whatever) and > > running them from Cygwin (or Wine) instead of MSYS. > > > > I think I'll skip the extra changes, as someone doing the above needs > > a clue-bat anyway. > > Err...that's not really uncommon. [...]
OK, but I still would accept those kinds of changes to code for little-used system only when someone has actually *tested* them in that particular situation, and found the code to be erroneous prior patch and working afterwards. We've been pestering other users to try out our patches for a good reason, I don't see why this should be treated less strict. Thanks, Ralf
