Jose, On 7/12/07, Jose Flavio Aguilar Paulino <[EMAIL PROTECTED]> wrote:
- I have to create a new kind of registers VREGS, because PowerPC has vector registers (Special ones 128bits longs only for special instructions) and the libunwind has General Use Registers and Flating Pointer Registers. So I had to create a dummy register array in x86.
Isn't a vector register the same size as a "long double"? If so, do you really need to add the *vregs() interface? I think you could just use the *fpregs() interface instead.
- Second, in some functions I had to add the a void pointer to ARGs, because I need in some cases to pass special parameters.
I didn't see those. Or did you get rid of that in the second patch?
- Third, I had to add new generic file for function pointer translate: Gget_func_addr.c. This is necessary because functions are called indirectly in Power. So, as in GDB, I need to create a dummy function for x86.
ia64 also uses function descriptors but we don't need Gget_func_addr.c. I'm not sure why it's needed for PPC either. Are you just trying to guard against ABI changes?
- Fourth, I add some Power specific tests
Looks good. What's with the addition of the "validate" member to unw_accessors_t? There already is a "validate" member in unw_addr_space_t, which is a lot more sensible. Just a typo? Just out of curiosity: why do you add a "Copyright Red Hat 2007" notice to libunwind-common.h.in? --david _______________________________________________ Libunwind-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/libunwind-devel
