On Fri, Sep 5, 2014 at 7:08 PM, Zhigang Liu <[email protected]> wrote: > This is the URL of the git repo. at the github. Can you give a code review? > > https://github.com/zliu2014/libunwind-tilegx >
Minor nits: $ git show | grep -P '\t' shows some lines with tabs were introduced. Could you convert them to spaces? +if !ARCH_TILEGX +SUBDIRS += doc +endif Don't think this should be needed. If you don't have all the tools installed, you can work around the problem via: touch doc/*.man I haven't reviewed the tilegx specific code carefully. Nothing jumped out at me so far. Happy to pull as long as tests are passing. -Arun _______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
