I just merged this. Thanks for your contribution! -Arun
On Tue, Sep 9, 2014 at 2:13 AM, Zhigang Liu <[email protected]> wrote: > Arun, > > Tabs in the C source code were removed. And the "docs" hack in the > Makefile.am was removed too. > Thanks for CR. > > ---ZhiGang @ Tilera > > https://github.com/zliu2014/libunwind-tilegx > [email protected]:zliu2014/libunwind-tilegx.git > > > $make check > ... > make check-TESTS > make[1]: Entering directory > `/u/zliu/WS1/libunwind-orig/latest/libunwind/tests' > PASS: test-proc-info > PASS: test-static-link > PASS: test-strerror > PASS: Gtest-bt > PASS: Ltest-bt > PASS: Gtest-exc > PASS: Ltest-exc > PASS: Gtest-init > PASS: Ltest-init > PASS: Gtest-concurrent > PASS: Ltest-concurrent > PASS: Gtest-resume-sig > PASS: Ltest-resume-sig > PASS: Gtest-resume-sig-rt > PASS: Ltest-resume-sig-rt > FAILURE: expected 13, not 1 frames below signal frame > XFAIL: Gtest-dyn1 > FAILURE: expected 13, not 1 frames below signal frame > XFAIL: Ltest-dyn1 > PASS: Gtest-trace > PASS: Ltest-trace > PASS: test-async-sig > PASS: test-flush-cache > PASS: test-init-remote > PASS: test-mem > PASS: Ltest-varargs > PASS: Ltest-nomalloc > PASS: Ltest-nocalloc > PASS: Lrs-race > PASS: test-ptrace > PASS: test-setjmp > PASS: run-check-namespace > PASS: run-ptrace-mapper > PASS: run-ptrace-misc > PASS: run-coredump-unwind > PASS: run-coredump-unwind-mdi > ====================================================== > All 34 tests behaved as expected (2 expected failures) > ====================================================== > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Arun > Sharma > Sent: Sunday, September 07, 2014 5:17 AM > To: Zhigang Liu > Cc: [email protected] > Subject: Re: [Libunwind-devel] Add TileGx platform support > > On Fri, Sep 5, 2014 at 7:08 PM, Zhigang Liu <[email protected]> wrote: >> This is the URL of the git repo. at the github. Can you give a code review? >> >> https://github.com/zliu2014/libunwind-tilegx >> > > Minor nits: > > $ git show | grep -P '\t' > > shows some lines with tabs were introduced. Could you convert them to spaces? > > +if !ARCH_TILEGX > +SUBDIRS += doc > +endif > > Don't think this should be needed. If you don't have all the tools installed, > you can work around the problem via: > > touch doc/*.man > > I haven't reviewed the tilegx specific code carefully. Nothing jumped out at > me so far. Happy to pull as long as tests are passing. > > -Arun _______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
