Hi,

NACK. You cannot change number_of_packets in
linux_usbfs.h:struct usbfs_urb from int to unsigned int,

linux_usbfs.h is a private copy of
/usr/include/linux/usbdevice_fs.h, to allow compiling with
older kernel-headers without a whole lot of #ifdef ugliness.

IOW this file defines the userspace kernel ABI and you cannot
just go and change that!

An alternative, and much simpler fix (untested) is probably
to just change num_retired from unsigned int to int.

Regards,

Hans




On 04/20/2012 10:42 AM, Ludovic Rousseau wrote:
> Hello,
>
> This patch is more instrusive since I changed the type of a
> number_of_packets in struct usbfs_urb from "int" to "unsigned int".
>
> I think the number_of_packets (on indexes) can not be negatif but I am
> not authoritative about that.
>
> I also had to change other "int" to "unsigned int" as a side effect.
>
> Jekins:
> I propose to use a high level of warnings in the Jenkins compilation
> farms so that the potential problems are more easy to spot.
>
> My CFLAGS is "-Wall -g -O2 -Wextra -pipe -funsigned-char
> -fstrict-aliasing -Wchar-subscripts -Wundef -Wshadow -Wcast-align
> -Wwrite-strings -Wunused -Wuninitialized -Wpointer-arith
> -Wredundant-decls -Winline -Wformat -Wformat-security -Wswitch-enum
> -Winit-self -Wmissing-include-dirs -Wmissing-prototypes
> -Wstrict-prototypes -Wold-style-definition -Wbad-function-cast
> -Wnested-externs -Wmissing-declarations"
>
> Bye
>
>
>
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
>
>
>
> _______________________________________________
> libusbx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/libusbx-devel

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
libusbx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to