Hi, On 04/24/2012 12:44 PM, Kustaa Nyholm wrote: > On 4/24/12 13:13, "Pete Batard"<p...@akeo.ie> wrote: > >> On 2012.04.24 07:38, Kustaa Nyholm wrote: >>> Thanks,but I think I was just curious for the actual technical issues >>> those new fields will cause. >> >> Well, to me the technical issue, is that in its current instance, >> Peter's patch completely ignores MS build environments, as well as any >> environment where git is not invokable by default. For instance, someone >> may fetch the repo on one platform and compile it onto another where git >> is not present - not a far fetched scenario for a secure corporate >> environment where internet access is limited to a few machines, or where >> libusb would be used with an internal distributed VCS that is different >>from git. > > Ah, so Peter's 'solution' (as I've said I've been tool lazy to look > at the code) to some perceived problem requires that the build environment > invokes git ?! Looks pretty broken to me.
Yes, not only that even if you've git it won't work when you build from a tarbal (like distro's and thus 99.9% of our end users do), so as said before I suggest we simply add the string for ABI compat and simply always make it the empty string as that is what it will be in distro builds anyways, then as a bonus document it is always empty -> case closed! Regards, Hans ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
