On Sun, Jun 17, 2012 at 8:00 PM, Peter Stuge <pe...@stuge.se> wrote:
> Xiaofan Chen wrote:
>> > Bug report to dlltool (actually invalid as pointed by Kai).
>> > http://sourceware.org/bugzilla/show_bug.cgi?id=14258
>>
>> On the other hand, Ruben disagreed with Kai and he
>> thinks that the library name is optional.
>
> This is not a subjective matter. MS is the authoritative
> specification, and in the specification the name is optional,
> so other tools implementing the same specification need to
> follow suit; not doing that is an unquestionable bug in dlltool.
>
> I guess that at some point the specification was different, and
> dlltool only implements the older version where the name wasn't
> optional.

As per Ruben, this only happens to the latest master branch
of binutils (dlltool) and the release version is okay.

>> In any case, the modification is benign and will work
>> with different version of dlltool, so I think it is good
>> to change libusb-1.0.def.
>
> Yes, I agree. Can you send the patch? Thanks!

Here it is.

>From 38d5776f728b121ebc0bf9db8da8d745317f55fd Mon Sep 17 00:00:00 2001
From: Xiaofan Chen <xiaof...@gmail.com>
Date: Sun, 17 Jun 2012 20:46:40 +0800
Subject: [PATCH] Some versions of dlltool may require a library name for
 libusb-1.0.def even though the library name is optional as
 specified by Microsoft. This patch adds the library name to
 libusb-1.0.def.

Reference thread in MinGW-w64 mailing list.
http://comments.gmane.org/gmane.comp.gnu.mingw.w64.general/5141
---
 libusb/libusb-1.0.def |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libusb/libusb-1.0.def b/libusb/libusb-1.0.def
index 847b785..3aba343 100644
--- a/libusb/libusb-1.0.def
+++ b/libusb/libusb-1.0.def
@@ -1,4 +1,4 @@
-LIBRARY
+LIBRARY "libusb-1.0.dll"
 EXPORTS
   libusb_alloc_transfer
   libusb_alloc_transfer@4 = libusb_alloc_transfer
-- 
1.7.7.5 (Apple Git-26)

-- 
Xiaofan

Attachment: 0001-Some-versions-of-dlltool-may-require-a-library-name.patch
Description: Binary data

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to