Okay, let me double-check: you prefer not to export the missing symbols
(make_program_args, etc..) even if it breaks building run-tests.exe with
shared libuv on Windows?
If so, I'll revert that part of my commit.


On Mon, Jun 8, 2015 at 2:09 PM, Saúl Ibarra Corretgé <[email protected]>
wrote:

>
> > - Builds and installs `run-tests` and `run-benchmarks`, too.
> > - Supports building shared lib (and Windows tests pass, unlike uv.gyp)
>
> Just to clarify, I see you exported the missing symbols on Windows, and
> that's not something we want to do. So no shared build will work with
> run-tests on Windows unless we address that, and that has nothing to do
> with CMake, GYP or whatever.
>
> --
> Saúl Ibarra Corretgé
> bettercallsaghul.com
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "libuv" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/libuv.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"libuv" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/libuv.
For more options, visit https://groups.google.com/d/optout.

Reply via email to