On 06/08/2015 05:32 PM, Tamás Kenéz wrote: > No problem, I see your point. > I reverted the 3 files which I modified and not added. >
Thanks! Much appreciated. > > On Mon, Jun 8, 2015 at 4:15 PM, Saúl Ibarra Corretgé <[email protected] > <mailto:[email protected]>> wrote: > > On 06/08/2015 03:53 PM, Tamás Kenéz wrote: > > Okay, let me double-check: you prefer not to export the missing symbols > > (make_program_args, etc..) even if it breaks building run-tests.exe with > > shared libuv on Windows? > > I know, that way tests cannot be run on Windows on the shared build, but > there doesn't seem to be a clean solution to this: if we copy the code > then the tests are useless if the code diverges, and there is no reason > to export those symbols, since they are only internally used. > > If you drop that part then users can just take those 2-3 files, drop > them on top of vanilla libuv and compile it using CMake. > > Same goes for that define you removed. > > You're free to do whatever you like with your fork, of course :-) but > yes, I'd rather see that part dropped for the reasons stated above. > > > Cheers, > > -- > Saúl Ibarra Corretgé > bettercallsaghul.com <http://bettercallsaghul.com> > > > -- > You received this message because you are subscribed to the Google > Groups "libuv" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to [email protected] > <mailto:libuv%[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/libuv. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google > Groups "libuv" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/libuv. > For more options, visit https://groups.google.com/d/optout. -- Saúl Ibarra Corretgé bettercallsaghul.com -- You received this message because you are subscribed to the Google Groups "libuv" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/libuv. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
