On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > > > > > > This is okay but this definitely wrong. And it does indeed sound > wrong. And > > > > it will always sound wrong. > > > > > > > > Being involved in a GSoC project is not about contributions. And also > > > > considering the scale of our project(some of the code even never got > > > > merged). There was a lot of research, design, planning, > implementation, > > > > review and finally the code got merged. > > > > > > > > I should at least be able to copyright the file. I mean, Jim was my > mentor, > > > > I did most of the work but his company copyright is right at the top > of the > > > > file - Does this sound okay to you ? > > > > > > You own copyright on any contributions you make, regardless of what any > > > Copyright statement at the top of the file says. Just like the Author > > > lines in file headers, these Copyright lines in source files are at > best > > > outdated and incomplete. Anyone who wishes to identify the copyright > > > ownership has no choice but to look at the git history which records > > > exactly who wrote what. > > > > Soo, can we also delete the "Copyright ..." lines from the top of the > > license statement? That's a cleanup which I'll gladly do. > > No, you can not delete other people's Copyright lines - they are considered > part of the license notice so can only be altered by the copyright holder. > Suse copyright notice has been on this file since the day this file got merged. To be honest, I did most of the original work so why should Suse copyright appear here while me doesn't ? > > The Author lines are not part of the license notice so that's free to be > modified or removed. > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/ > dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/ > dberrange :| >
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list