On Wed, Mar 8, 2023 at 12:16 PM Michal Privoznik <[email protected]>
wrote:

> Technically, there's nothing libnuma specific about
> virNumaNodesetToCPUset(). It just implements a generic algorithm
> over virNumaGetNodeCPUs() (which is then libnuma dependant).
> Nevertheless, there's no need to have this function living inside
> WITH_NUMACTL block. Any error returned from virNumaGetNodeCPUs()
> (including the one that !WITH_NUMACTL stub returns) is propagated
> properly.
>
> Move the function out of the block into a generic one and drop
> the !WITH_NUMACTL stub.
>
> Signed-off-by: Michal Privoznik <[email protected]>
> ---
>  src/util/virnuma.c | 115 +++++++++++++++++++++------------------------
>  1 file changed, 53 insertions(+), 62 deletions(-)
>


Reviewed-by: Kristina Hanicova <[email protected]>

Kristina

Reply via email to