On Wed, Mar 8, 2023 at 12:16 PM Michal Privoznik <[email protected]>
wrote:

> While it's true that anybody who's interested in getting
> .host-nodes attribute value can just use
> virJSONValueObjectGetArray() (and that's exactly what
> qemuBuildThreadContextProps() is doing, btw), it somebody is
>

*if


> interested in getting the actual virBitmap, they would have to
> parse the JSON array.
>
> Instead, introduce an argument to qemuBuildMemoryBackendProps()
> which is set to corresponding value used when formatting the
> attribute.
>
> Signed-off-by: Michal Privoznik <[email protected]>
> ---
>  src/qemu/qemu_command.c | 40 ++++++++++++++++++++++++----------------
>  src/qemu/qemu_command.h |  4 +++-
>  src/qemu/qemu_hotplug.c |  2 +-
>  3 files changed, 28 insertions(+), 18 deletions(-)
>


Reviewed-by: Kristina Hanicova <[email protected]>

Kristina

Reply via email to