On Wed, Mar 8, 2023 at 12:17 PM Michal Privoznik <[email protected]> wrote:
> Since qemuxml2argvtest is now using virnumamock, there's no need > for qemuxml2argvmock to offer reimplementation of virNuma*() > functions. Also, the comment about CLang and FreeBSD (introduced > in v4.3.0-40-g77ac204d14) is no longer true. Looks like noinline > attribute was the missing culprit. > > Signed-off-by: Michal Privoznik <[email protected]> > --- > src/util/virnuma.h | 2 +- > ...-unavailable-restrictive.x86_64-latest.err | 2 +- > ...mnode-unavailable-strict.x86_64-latest.err | 2 +- > ...umatune-static-nodeset-exceed-hostnode.err | 2 +- > tests/qemuxml2argvmock.c | 41 ------------------- > 5 files changed, 4 insertions(+), 45 deletions(-) > I think you can also drop include of virnuma.h in tests/qemuxml2argvmock.c Reviewed-by: Kristina Hanicova <[email protected]> Kristina
