On 02/15/2011 05:01 PM, Eric Blake wrote: > * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) > (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. > (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. > ---
> rc = virFileWriteStr(keypath, value, 0);
> if (rc < 0) {
> - DEBUG("Failed to write value '%s': %m", value);
> rc = -errno;
> + VIR_DEBUG("Failed to write value '%s': %m", value);
Should we go one step further and guarantee that VIR_DEBUG() does not
modify errno?
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
