On 02/17/2011 04:01 AM, Jiri Denemark wrote: >> Followup to commit 17e19add, and would have prevented the bug >> independently fixed in commit 76c57a7c. >> > I would have implemented this as > > if (...) > - return; > + goto out; > > ... > > VIR_FREE(msg); > + > +out: > + errno = saved_errno; > }
Yeah, that does look a bit nicer. > > to avoid having to set errno in several places but I can live with your > solution too :-) > > ACK regardless on which one of the two versions you decide to push. Pushed with the modification to use goto. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
