On 07/14/2011 08:08 AM, Daniel P. Berrange wrote: >> That would be a valid concern if we passed internal flags over the wire, >> but we don't. > > I'm thinking about the case where a value we currently use for an > internal flag, gets used for a public flag in the future. In that > case, any client side checks for curent internal flags would be > bogus.
Then we already have the bogus situation, where libvirt.c is silently filtering out internal flags. Either we must not use the public flags argument for internal flags (and thus fix driver.h to give the callback an internalFlags argument), or we are already publicly limited to at most 16 bits for virDomainGetXMLDesc due to older clients silently ignoring the upper bits. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
