On Thu, 09 Mar 2006 00:56:32 -0000, Sean Chittenden <[EMAIL PROTECTED]>  
wrote:

>> Okay, for now I put in an #error thats hit if RUBY_LIBXML_VERNUM !=
>> RUBY_LIBXSLT_VERNUM , so it won't compile if the headers
>> mismatch. Pretty crude I know but I had problems comparing the
>> versions, because right now they're octal consts in the source, but
>> will become decimal at version 1.x. I guess it could just check the
>> string versions instead or something... ?
>
> I've used multiple macros in the past and compared them
> individually... sucks, but auto* makes it a bit nicer.
>
> #define MAJOR_VER 0
> #define MINOR_VER 3
> #define MICRO_VER 5
>

I considered that, but I'd have liked to be able to do a release against  
the 0.3.6 libxml release, and adding that to the headers would break that  
I think. Only a problem for those who compile from CVS, but...?

>> I also added a LIBXML_TEST_VERSION in the Init_libxslt func, I
>> couldn't find an equivalent in libxslt but it shouldn't be difficult
>> to do. I guess libxml-ruby should have the same thing...
>>
>> Apart from that I think this codebase should go into CVS, I've not
>> lost any data for, ooh, days and I'm starting to get jittery having
>> uncommitted stuff ;)
>
> plz to be committing your code two minutes ago
>

Phew, that's better :) Module is 'libxslt'. It's compiling and testing  
clean here, you can just run 'rake' to compile and test, hopefully...

-- 
Ross Bamford - [EMAIL PROTECTED]
_______________________________________________
libxml-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/libxml-devel

Reply via email to