On Thu, 09 Mar 2006 02:20:41 -0000, Sean Chittenden <[EMAIL PROTECTED]>  
wrote:

>> >> Okay, for now I put in an #error thats hit if RUBY_LIBXML_VERNUM
>> >> != RUBY_LIBXSLT_VERNUM , so it won't compile if the headers
>> >> mismatch. Pretty crude I know but I had problems comparing the
>> >> versions, because right now they're octal consts in the source,
>> >> but will become decimal at version 1.x. I guess it could just
>> >> check the string versions instead or something... ?
>> >
>> > I've used multiple macros in the past and compared them
>> > individually... sucks, but auto* makes it a bit nicer.
>> >
>> > #define MAJOR_VER 0
>> > #define MINOR_VER 3
>> > #define MICRO_VER 5
>> >
>>
>> I considered that, but I'd have liked to be able to do a release
>> against the 0.3.6 libxml release, and adding that to the headers
>> would break that I think. Only a problem for those who compile from
>> CVS, but...?
>
> Naw, that won't break ABI and can be injected at any time.
>

Okay, I implemented this in both, and updated the version check. It does  
mean that it won't be possible to compile this libxslt-ruby release with  
headers from the libxml-ruby 0.3.6 release but since we're bundling the  
headers it only really affects people who check out just libxslt-ruby from  
CVS, and try to install the headers themselves...

-- 
Ross Bamford - [EMAIL PROTECTED]
_______________________________________________
libxml-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/libxml-devel

Reply via email to