2007/6/25, Jon Keating <[EMAIL PROTECTED]>:
I usually do make docs, but doxy is fine too.
make docs it is then.
Here are a few more suggestions that I could think (with some help from C++ Coding Standards - 101 Rules, Guidelines, And Best Practices) of for coding style:
Except for the ones I've commeted on below, I fully agree.
* Don't use varargs. We are currently using it in ICQUser::usprintf(). We should change how usprintf works. Which leads to the next point...
I don't think we should ban varargs. For e.g. log functions it's really useful. But we should try very hard to avoid it.
* Don't make use of functions that use varargs, such as sprintf, printf, etc functions
The same here, for some problems, it's just the best solution to use snprintf and friends. But as above, try to avoid them but if needed use the secure variants (that take a size argument).
* Make use of exceptions for error reporting
I agree that we should use exceptions, but we have to be careful when throwing across DSO:s (http://gcc.gnu.org/wiki/Visibility).
* Use STL and algorithms instead of self-made loops (use boost::lambda as necessary)
Where it makes sense, I'm all for it. // Erik -- Erik Johansson http://ejohansson.se/
