Some comments on r5026:

addToModifyUsers() should take a const std::string reference as second
arg to avoid unnecessary copies.

Additionally, I think that function declarations should include the
name for all parameters.

line 4305: I think if (pending.length()) should be if (!pending.empty()).

// Erik

--
Erik Johansson
http://ejohansson.se/

Reply via email to