On Apr 12, 2005 7:10 PM, Kevin Krammer <[EMAIL PROTECTED]> wrote:
> You can use the command line dcop tool for all the string based methods or
> kdcop the GUI tool, for example

Thanks for the info. There is just one problem I found with this. It
isn't an immediate problem, but can be one in the future when we
implement more protocols.

Let's imagine we have an AIM user called 'licquser' and a Yahoo User
called 'licquser'. We tell DCOP to send a message to 'licquser'. The
KABC lookup will return the string 'licquser' and then we compare it
with the contact list:

    FOR_EACH_USER_START(LOCK_R)
    id = pUser->IdString();
    if (!id.isEmpty() && id == licqID)
    {
        ppid = pUser->PPID();
        found = true;
        FOR_EACH_USER_BREAK
    }
    FOR_EACH_USER_END

This will find a 'licquser', but which one? It depends on the way it
is hashed  when Licq loads the users. The correct method, would be to
get a Protocol string. (MSN, Licq, Yahoo, etc.) and use the
FOR_EACH_PROTO_USER_START() macro to guarantee that we have the user
we want. If the Protocol isn't specified, we can just go with the
FOR_EACH_USER_START() macro and do whatever, since the user didn't
specify.

So, we will need a way to get the PPID passed to DCOP and then pass it
to Licq so we can differentiate users of different protocols with the
same Id. I'd like to have this fixed now, so it won't be an annoying
problem that creeps up on us when we implement more protocols. I'd
like to see this in Licq soon, but if it's too much work, just let me
know and I can help out. Thanks for writing this patch, it looks like
it is very promising and everything else looks alright with it.

Jon


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Licq-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/licq-devel

Reply via email to