On the whole, looks quite tidy. However, what made you go for the Loggable trait? Why dont you use lift's backed in logging utilities?
The only other thing possibly to consider would be parallel executing snippets - im not sure if its 100% applicable for your use case, but maybe it could work for you and remove the Parallelizer stuff. Moreover, is there a reason your not just using an Actor? and the !? method? And one last thing would be that I would suggest replacing some of your manual onclick stuff in the PhotoRows trait with lifts JS infrastructure. Is that of any help?! Cheers, Tim On Dec 13, 6:44 am, Dave Briccetti <[email protected]> wrote: > For a lightning talk at Bay Area Scala Enthusiasts at Twitter HQ > Monday, I will show BirdShow, a Lift application that shows photos > from Flickr. The current instantiation is a nature photography Web > site. Would some of you Lift experts be willing to review the code and > comment on the application? I want this to be an example of good Scala > and Lift coding. I will gladly acknowledge your help in the > presentation. > > http://briccettiphoto.comhttp://github.com/dcbriccetti/bird-show -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
