Dave, I have updated your application to Lift 1.1-SNAPSHOT on my github fork [1] and sent you a pull request. This basically covers #1 thru' #4 in my list.
Feel free to merge if it interests you. [1] http://github.com/indrajitr/bird-show Cheers, Indrajit On Dec 14, 12:25 am, Indrajit Raychaudhuri <[email protected]> wrote: > On 14/12/09 12:06 AM, Timothy Perrett wrote: > > > The point about snippets is a subjective one - it depends what Dave is > > trying to show in his presentation.... my thought would be to leave > > them as they are because it makes lift appear simpler (that is, there > > is auto-wire-up). > > Point taken. > > > > > However, for production, stateless snippets should be objects with > > manual wireup in boot. > > This is where I was coming from. > > > > > > > Cheers, Tim > > > On Dec 13, 6:02 pm, Indrajit Raychaudhuri<[email protected]> wrote: > >> Very tidy indeed! I like the style and formatting :) > > >> Some more points in addition to what Tim mentioned: > > >> 1. The application is based on Lift 1.0 and Scala 2.7.3. Moving to Lift > >> 1.1 (with Scala 2.7.7) would be recommended. Lift 1.1-SNAPSHOT should be > >> fine or wait for the Lift 1.1-M8 (announcement should come in a day or > >> two) if you prefer non-SNAPSHOT dependency. > > >> 2. No need for dependency on lift-core, just lift-webkit should be fine. > > >> 3. Dependency on org.scala-lang:scala-library won't be necessary. Mavne > >> would pick that up transistively. > > >> 4. The application doesn't use DB. Thus no need for dependency on derby > >> (unless you have future plan) > > >> 5. Mention a quick inline note on why you have LiftRules.enableLiftGC = > >> false > > >> 6. Some of the snippets are good candidate of being DispatchSnippet > >> (some of them being Stateful) instead of using reflection all the while. > >> Remember to use LiftRules.snippetDispatch.append in this case. > > >> 7. For the purpose of demonstrating ResourceServer, consider moving > >> birdshow.css, birdshow.js, Elanor.JPG to resources/toserve/.... Remember > >> to use ResourceServer.allow when you do this. The paths in html would > >> also change accordingly to "/classpath/...". > > >> Hope this is useful :) > > >> Cheers, Indrajit > > >> On 13/12/09 9:48 PM, Timothy Perrett wrote: > > >>> On the whole, looks quite tidy. However, what made you go for the > >>> Loggable trait? Why dont you use lift's backed in logging utilities? > > >>> The only other thing possibly to consider would be parallel executing > >>> snippets - im not sure if its 100% applicable for your use case, but > >>> maybe it could work for you and remove the Parallelizer stuff. > >>> Moreover, is there a reason your not just using an Actor? and the !? > >>> method? > > >>> And one last thing would be that I would suggest replacing some of > >>> your manual onclick stuff in the PhotoRows trait with lifts JS > >>> infrastructure. > > >>> Is that of any help?! > > >>> Cheers, Tim > > >>> On Dec 13, 6:44 am, Dave Briccetti<[email protected]> wrote: > >>>> For a lightning talk at Bay Area Scala Enthusiasts at Twitter HQ > >>>> Monday, I will show BirdShow, a Lift application that shows photos > >>>> from Flickr. The current instantiation is a nature photography Web > >>>> site. Would some of you Lift experts be willing to review the code and > >>>> comment on the application? I want this to be an example of good Scala > >>>> and Lift coding. I will gladly acknowledge your help in the > >>>> presentation. > > >>>>http://briccettiphoto.comhttp://github.com/dcbriccetti/bird-show > > >>> -- > > >>> You received this message because you are subscribed to the Google Groups > >>> "Lift" group. > >>> To post to this group, send email to [email protected]. > >>> To unsubscribe from this group, send email to > >>> [email protected]. > >>> For more options, visit this group > >>> athttp://groups.google.com/group/liftweb?hl=en. > > > -- > > > You received this message because you are subscribed to the Google Groups > > "Lift" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group > > athttp://groups.google.com/group/liftweb?hl=en. -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
