Let's keep the unpacked excanvas for the sake of consistency. Using YUI
compressor at build time is what lift-webkit does at the moment.
How about injecting the excanvas JS conditionally (via ieMode)? This is
mostly cosmetic though.
Cheers, Indrajit
On 30/01/10 6:14 AM, Peter Robinett wrote:
Aaron, thanks so much for taking the initiative to upgrade Flot, it's
something that I've been meaning to do. Just skimming over your
changes, everything looks good. As for not using the packed excanvas
file, that should be ok since Lift runs the YUI compressor by default
on all Javascript files (correct, David?). Of course, broken URLs need
to be fixed.
David, how do we go about merging these changes?
Peter
On Jan 29, 3:32 pm, Aaron Valade<a...@alum.mit.edu> wrote:
There is one break that my commit made which I just realized after I
had sent this email in that I deleted the excanvas.pack.js file and
dropped in the excanvas.js that was included with the Flot 0.6
distribution but didn't rename it to be excanvas.pack.js and didn't
change the path in the Flot.scala file.
I can make an additional commit that fixes this, if it pleases the court. :-)
- A
On Fri, Jan 29, 2010 at 6:15 PM, David Pollak
<feeder.of.the.be...@gmail.com> wrote:
Peter,
What do you think of the upgrade (given that you're the most Flot-ish Lift
committer)?
Thanks,
David
On Fri, Jan 29, 2010 at 12:32 PM, Aaron Valade<a...@alum.mit.edu> wrote:
Hello all,
I needed to use some of the recent functionality in the Flot jQuery
plugin which is version 0.6. The Flot lift-widget is currently at
0.4. So I upgraded it to use the new version and I've posted the
commit on github:
http://github.com/avalade/liftweb/commit/fa3d76fb72a7f74d13265e4039f0...
Version 0.6 of Flot does make one breaking change which requires some
of the options which were previously described as a top level
attributes on the FlotOptions object to be pushed inside of a new
attribute called FlotSeriesOptions. I've made the appropriate changes
to the various example Flot charts which were included in the flotDemo
module.
Would it be possible to get this change upstream?
- Aaron
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to lift...@googlegroups.com.
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
--
Lift, the simply functional web frameworkhttp://liftweb.net
Beginning Scalahttp://www.apress.com/book/view/1430219890
Follow me:http://twitter.com/dpp
Surf the harmonics
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to lift...@googlegroups.com.
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to lift...@googlegroups.com.
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
