Tim,
Sorry. I was chasing a use case where control characters can still make it
into the XML output. Turns out that the Scala compiler converts
<b>{expression}</b> into an Atom, not into a Text() element. Because of
this, it was possible for control characters to sneak into output.
I went around our review board rules after testing the fix on a simple app
(one, it turns out that didn't include a script.)
I will be more careful with stuff that could break all things in the future.
Thanks,
David
PS -- Thanks Indrajit for reversing the commit.
On Wed, Feb 24, 2010 at 3:14 AM, Timothy Perrett <[email protected]>wrote:
> Guys,
>
> I see DPP made a bunch of commits last night. Something in there has
> fundamentally broken the markup parser. Yesterday I deploy an
> application to production and today I go to update a small bit of copy
> that marketing want changed and i'm finding that my application is
> broken....
>
> With LiftRules.useXhtmlMimeType = false in Boot, I see the following:
>
> <script type="text/javascript">
> // <![CDATA[
> jQuery(document).ready(function()
> {liftAjax.lift_successRegisterGC();});
> var lift_page = "F1075228527421HHA";
> // ]]>
> </script>
>
> This is obviously problematic and all my javascript in my application
> is now doing this. Sorry to be grizzly about this, but its totally
> untenable for me to be building apps that work one day and are broken
> the next... I tried reverting to 2.0-M2, but that was giving me errors
> about not being able to boot SessionMaster. If we are changing stuff
> in the core of Lift, we need a good number of eyes (that is, people
> who are ACTIVE committers) on the changes in review board otherwise
> stuff like this happens (certainly, I don't remember getting review
> requests for any of these changes that are now causing me
> problems...)
>
> I have to get this fixed today otherwise im going to be seriously
> flamed.
>
> A very unhappy Tim.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Lift" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected]<liftweb%[email protected]>
> .
> For more options, visit this group at
> http://groups.google.com/group/liftweb?hl=en.
>
>
--
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Surf the harmonics
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
