My concern about putting this in LiftRules is that not all applications that could benefit from the new logging support will use webkit, since the logging is in common.
Maybe a bridge method in LiftRules to put it in a convenient place, but I think the actual work should be exposed nearby the logging library. -Ross On Feb 25, 2010, at 1:42 PM, Marius wrote: > Why not? LiftRules is about configuring a lift app at startup. > > On 25 feb., 16:56, Naftoli Gugenheim <naftoli...@gmail.com> wrote: >> Why should an initLogger method be in LiftRules? >> >> ------------------------------------- >> >> Marius<marius.dan...@gmail.com> wrote: >> >> Then perhaps: >> >> LiftRules.initLogger(Log4J) >> >> On Feb 25, 12:16 pm, Jeppe Nejsum Madsen <je...@ingolfs.dk> wrote: >> >>> On Thu, Feb 25, 2010 at 10:32 AM, Marius <marius.dan...@gmail.com> wrote: >>>> I'd opt in for something like: >> >>>> LiftRules.logger = Log4J >> >>> Agree this fits the current idioms, but how should this be triggered? >>> The new logging code is in lift-common so cannot call stuff in >>> LiftRules. >> >>> Note we're not talking about Loggers (objects that have warn & info >>> methods) but about configuring the logging system, which needs to be >>> done before Loggers can be used. >> >>> /Jeppe >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Lift" group. >> To post to this group, send email to lift...@googlegroups.com. >> To unsubscribe from this group, send email to >> liftweb+unsubscr...@googlegroups.com. >> For more options, visit this group >> athttp://groups.google.com/group/liftweb?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Lift" group. > To post to this group, send email to lift...@googlegroups.com. > To unsubscribe from this group, send email to > liftweb+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/liftweb?hl=en. > -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to lift...@googlegroups.com. To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
