Folks let's keep in mind that even now users can decide whichever version they want for the underlying js script framework. Just override
override def pathRewriter: PartialFunction[List[String], List[String]] from the JsArtifacts. JQuery13Artifacts and JQuery14Artifacts are just helpers and IMHO these should point to the minified versions. Br's, Marius On 3 mar., 20:39, Peter Robinett <[email protected]> wrote: > I like Jeppe's option: > > > Or 2.5: use 1. for the js artifacts included with Lift and let the user > > decide how to handle their own js files. I would hate to be forced into > > using the yui compressor for my own files that I put in toserve (not > > that it isn't a good idea :-) > > This lets us keep plain js source in Lift (makes upgrading included js > artifacts easier and gives nicer diffs) while giving the user complete > control over their own files (e.g. perhaps they don't want a file > minified in test mode so that they can more easily track method calls > via Firebug). > > Peter > > On Mar 3, 9:19 am, Indrajit Raychaudhuri <[email protected]> wrote: > > > > > On 03/03/10 10:21 PM, Jeppe Nejsum Madsen wrote: > > > > Indrajit Raychaudhuri<[email protected]> writes: > > > > [...] > > > >> My interest in the current context, is to have consistent behavior in > > >> the js artifacts bundled with Lift. > > > >> To me (and Marius) #2 is also worth consideration. True that you'd > > >> have a compressed (IDE unfriendly) js in the codebase but you'd also > > >> be able to remove build-time dependency on yui compressor. (one less > > >> dependency, one less step etc.) > > > > But why is it a problem with the build-time dependency on yui compressor > > > if it only concerns the building of the lift-*.jar? Or am I missing > > > something? > > > No question with the worthiness of yui-compressor as such, it does the > > job perfectly and great for the purpose :) It about when to use it. > > > If we are using it to minify the set of third party js files (jquery, > > json etc.) repeatedly which never change we might as well consider > > keeping the minified form directly. Hence the worthiness behind > > consideration. Note that Lift's internal js files (e.g., jlift.js) are > > fine going the yui-compressor route. > > > But more than anything, we need to be consistently following either of > > these (particularly for the 3rd party js artifacts). > > > > Ideally the lift jars should contain both, and the non-minified used in > > > development..... > > > Yes, better. Which actually led to the other thought (#3). But git > > should contain only one form in that case (the un-minified one). > > > > /Jeppe -- You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/liftweb?hl=en.
