Easier diff check for this issue:
https://codereview.appspot.com/319380043/
This is not the actual patch but simply the diffs of the files that changed. As
these are snippets and as they were all autogenerated, I had to edit the
snippet and copy then to ../snippets/new/.. so they get generated by the doc
build into ../snippets/.. correctly. However that meant all these files were
'new' and so diffing them visually would be hard.
This 'rietveld' is to help with that.
---
** [issues:#5039] Replace \set Staff.instrumentName with \with form in doc
examples**
**Status:** Started
**Created:** Sun Jan 22, 2017 10:46 PM UTC by Trevor Daniels
**Last Updated:** Sun Feb 19, 2017 05:57 PM UTC
**Owner:** pkx166h
In http://lists.gnu.org/archive/html/lilypond-user/2017-01/msg00500.html dak
wrote:
> But stuff like instrument names actually is a static property of the
staff. You really, really should set it like
> \new Staff \with { instrumentName = "Treble Recorder" }
{
\grace f'8
g'4 g'
}
Perhaps we should aim to convert all the LilyPond examples in the docs which use
\set Staff.instrumentName = " ... "
to the `\new Staff \with { ... }` form.
There are quite a lot, and many more in the LSR, regression tests, etc.
---
This is/has been broken down into a number of small patches to make reviewing
easier.
http://codereview.appspot.com/313400043 - Notation Reference patch (now pushed)
http://codereview.appspot.com/314390043 - Learning Manual patch (now pushed)
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
