- **labels**:  --> Fixed_2_19_57, Fixed_2_19_56
- Description has changed:

Diff:

~~~~

--- old
+++ new
@@ -1,3 +1,15 @@
+Note to Verifiers:
+
+This is/has been broken down into a number of small patches to make reviewing 
easier.
+
+http://codereview.appspot.com/313400043 - Notation Reference patch (now pushed 
- fixed 2_19_56)
+
+http://codereview.appspot.com/314390043 - Learning Manual patch (now pushed - 
fixed 2_19_56)
+
+http://codereview.appspot.com/313620043 - All Snippets (now pushed - fixed 
2_19_57)
+
+
+
 In http://lists.gnu.org/archive/html/lilypond-user/2017-01/msg00500.html dak 
wrote:
 
 > But stuff like instrument names actually is a static property of the
@@ -17,16 +29,10 @@
 There are quite a lot, and many more in the LSR, regression tests, etc.
 
 ---
-This is/has been broken down into a number of small patches to make reviewing 
easier.
-
-http://codereview.appspot.com/313400043 - Notation Reference patch (now 
pushed) 
-
-http://codereview.appspot.com/314390043 - Learning Manual patch (now pushed)
-
-http://codereview.appspot.com/313620043 -  Snippets (in review)
 
 
 
 
 
 
+

~~~~

- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

author  James Lowe <[email protected]>       
        Sat, 18 Feb 2017 11:51:05 +0000 (11:51 +0000)
committer       James Lowe <[email protected]>       
        Sun, 26 Feb 2017 20:13:31 +0000 (20:13 +0000)
commit  3f57efa0cde39bf0642fb6fb3672a19262ceda83



---

** [issues:#5039] Replace \set Staff.instrumentName with \with form in doc 
examples**

**Status:** Fixed
**Labels:** Fixed_2_19_57 Fixed_2_19_56 
**Created:** Sun Jan 22, 2017 10:46 PM UTC by Trevor Daniels
**Last Updated:** Sun Feb 26, 2017 07:09 PM UTC
**Owner:** pkx166h


Note to Verifiers:

This is/has been broken down into a number of small patches to make reviewing 
easier.

http://codereview.appspot.com/313400043 - Notation Reference patch (now pushed 
- fixed 2_19_56)

http://codereview.appspot.com/314390043 - Learning Manual patch (now pushed - 
fixed 2_19_56)

http://codereview.appspot.com/313620043 - All Snippets (now pushed - fixed 
2_19_57)



In http://lists.gnu.org/archive/html/lilypond-user/2017-01/msg00500.html dak 
wrote:

> But stuff like instrument names actually is a static property of the
staff.  You really, really should set it like

> \new Staff \with { instrumentName = "Treble Recorder" }
{
  \grace f'8
  g'4 g'
}

Perhaps we should aim to convert all the LilyPond examples in the docs which use

    \set Staff.instrumentName = " ... "

to the `\new Staff \with { ... }` form.
There are quite a lot, and many more in the LSR, regression tests, etc.

---










---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

Reply via email to