- **Needs**: -->
- **Patch**: new --> needs_work
- **Type**: --> Enhancement
- **Comment**:
This fails make check.
It fails on a number of different reg tests but all with the same basic error.
Example:
~~~
/home/james/lilypond-git/input/regression/chord-names-lower-case-minor.ly'
warning: cannot find property type-check for `chord-semantics' (music-type?).
perhaps a typing error?
Writing timing to 77/lily-34d19eca.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5ce7c0>) >
continuing, cross fingers
~~~
and
~~~
/home/james/lilypond-git/input/regression/fret-diagrams-fret-label.ly'
warning: cannot find property type-check for `chord-semantics' (music-type?).
perhaps a typing error?
Writing timing to 97/lily-43513982.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5c8ba0>) >
continuing, cross fingers
~~~
and
~~~
/home/james/lilypond-git/input/regression/chord-semantics-bass.ly'
warning: type check for `chord-step' failed; value `bass' must be of type `pair'
warning: cannot find property type-check for `chord-semantics' (music-type?).
perhaps a typing error?
Writing timing to d3/lily-efd6a06c.profile...
programming error: Parsed object should be dead: #<Lily_lexer (#<module
2b102b5cc860>) >
continuing, cross fingers
~~~
etc.
---
** [issues:#5224] Update EventChord to include a ChordSemantics event entry
which captures input semantic information from chord mode and uses it to create
chord names.**
**Status:** Started
**Created:** Wed Nov 01, 2017 02:07 AM UTC by Charles Winston
**Last Updated:** Fri Dec 29, 2017 10:39 PM UTC
**Owner:** Charles Winston
Update EventChord to include a ChordSemantics event entry which captures input
semantic information from chord mode and uses it to create chord names.
Without these semantics, naming chords based only on their notes results in
ambiguous naming:
Example: Cm7 no root and Eb both have the exact same notes, and so there is no
way to differentiate between them, unless we capture the data from chord mode:
{ cm:7.1 } as opposed to { eb }
https://codereview.appspot.com/337870043
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
