- **Needs**: -->
- **Patch**: new --> needs_work
- **Type**: --> Enhancement
- **Comment**:
Fails make check
input/regression/chord-names-languages.ly'
~~~
Parsing...
Renaming input to:
`/home/james/lilypond-git/input/regression/chord-names-languages.ly'
warning: type check for `bass' failed; value `(#t . #t)' must be of type
`boolean'
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:267:59:
In procedure memoization in expression (if ba
ss (write-me "base3: " bass) ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:267:59:
In file "/home/james/lilypond-git/build/out/s
hare/lilypond/current/scm/chord-entry.scm", line 266: Missing or extra
expression in (if bass (write-me "base3: " bass) (list (make
-note-ev bass (quote bass) #t)) (quote ())).
~~~
and
input/regression/chord-name-entry.ly
~~~
Parsing...
Renaming input to:
`/home/james/lilypond-git/input/regression/chord-name-entry.ly'Backtrace:
In unknown file:
?: 0* [lilypond-main #]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1032: 1* (let* ((failed #)) (if (ly:get-option #) (begin #)) ...)
1032: 2* [lilypond-all #]
1045: 3 (let* ((failed #) (separate-logs #) (ping-log #) ...) (gc) ...)
1057: 4* [for-each #<procedure #f #> #]
In unknown file:
?: 5* [#<procedure #f (x)> "d9/lily-4b39608d.ly"]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1059: 6* (let* (# # #) (if separate-logs #) (if ping-log #) ...)
1070: 7* [lilypond-file #<procedure #f (key failed-file)>
"d9/lily-4b39608d.ly"]
1105: 8 [catch ly-file-failed #<procedure #f ()> #<procedure #f (x . args)>]
In unknown file:
?: 9* [#<procedure #f ()>]
In /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
1106: 10* [ly:parse-file "d9/lily-4b39608d.ly"]
In unknown file:
?: 11* [construct-chord-elements #<Pitch c > #<Duration 1 > ...]
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:
31: 12* (let* (# # # # ...) (letrec # # # ...))
In unknown file:
?: 13 (letrec (# # # ...) (set! root #) ...)
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/chord-entry.scm:
176: 14* (set! complete-chord (if start-additions # #))
177: 15* (if start-additions (interpret-additions base-chord flat-mods ...)
...)
178: 16 [interpret-additions (# # # ...) (#<procedure sus-modifier #> #) ...]
...
98: 17 [interpret-additions ((# # #) (# # #) (# # #)) (#<Pitch f' >) ...
100: 18* [((modifier . #f) (root . #<Pitch c' >) (extension . 7) ...)]
~~~
---
** [issues:#5224] Update EventChord to include a ChordSemantics event entry
which captures input semantic information from chord mode and uses it to create
chord names.**
**Status:** Started
**Created:** Wed Nov 01, 2017 02:07 AM UTC by Charles Winston
**Last Updated:** Sat Aug 11, 2018 03:03 PM UTC
**Owner:** Charles Winston
Update EventChord to include a ChordSemantics event entry which captures input
semantic information from chord mode and uses it to create chord names.
Without these semantics, naming chords based only on their notes results in
ambiguous naming:
Example: Cm7 no root and Eb both have the exact same notes, and so there is no
way to differentiate between them, unless we capture the data from chord mode:
{ cm:7.1 } as opposed to { eb }
https://codereview.appspot.com/337870043
---
Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
