- Description has changed:
Diff:
~~~~
~~~~
- **Needs**: -->
- **Patch**: new --> needs_work
- **Type**: --> Enhancement
- **Comment**:
Fails make.
~~~
...
LILYPOND_VERSION=2.21.0 PDFTEX=pdfetex PDFLATEX=pdflatex /usr/bin/python -tt
/home/james/lilypond-git/scripts/lilypond-book.py -I
/home/james/lilypond-git/Documentation -I ./out -I
/home/james/lilypond-git/build/Documentation/snippets/out -I
/home/james/lilypond-git/Documentation/included -I
/home/james/lilypond-git/Documentation/pictures -I
/home/james/lilypond-git/Documentation -I
/home/james/lilypond-git/input/regression --process='true -dbackend=eps
--formats=ps,png,pdf -djob-count=4 -dinclude-eps-fonts -dgs-load-fonts
--header=doctitle --header=doctitleca --header=doctitlecs --header=doctitlede
--header=doctitlees --header=doctitlefr --header=doctitlehu --header=doctitleit
--header=doctitleja --header=doctitlenl --header=doctitlezh --header=texidoc
--header=texidocca --header=texidoccs --header=texidocde --header=texidoces
--header=texidocfr --header=texidochu --header=texidocit --header=texidocja
--header=texidocnl --header=texidoczh -dcheck-internal-types -ddump-signatures
-danti-alias-factor=2
-dfont-export-dir=/home/james/lilypond-git/build/out-fonts -O TeX-GS'
--output=./out --format=texi --loglevel=WARN --skip-lily-check
--lily-output-dir /home/james/lilypond-git/build/out/lybook-db
--redirect-lilypond-output /home/james/lilypond-git/Documentation/snippets.tely
langdefs.py: warning: lilypond-doc gettext domain not found.
lilypond-book.py: error: file not found: legacy.itely
/home/james/lilypond-git/./make/ly-rules.make:26: recipe for target
'out/snippets.texi' failed
make[1]: *** [out/snippets.texi] Error 1
make[1]: Leaving directory '/home/james/lilypond-git/build/Documentation'
/home/james/lilypond-git/stepmake/stepmake/generic-targets.make:6: recipe for
target 'all' failed
make: *** [all] Error 2
~~~
---
** [issues:#5449] Chord names clean-up; no more Banter, exceptionsPartial or
\powerChords.**
**Status:** Started
**Created:** Mon Dec 17, 2018 05:23 PM UTC by Valentin Villenave
**Last Updated:** Mon Dec 17, 2018 10:18 PM UTC
**Owner:** Valentin Villenave
Chord names clean-up; no more Banter, exceptionsPartial or \powerChords.
This rather large patch
- removes the legacy code for unsupported non-Ignatzek chord names;
that code hasn’t been working properly for nearly 15 years anyway, see
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00288.html
- stores a version of this code, with minor corrections, as a
self-contained snippet (for historical purposes mainly), both
on the LSR (as an upgrade to snippet #102) and in a dedicated
subsection of the Snippets doc page.
- as a result, chord-generic-names.scm is no longer found in scm/
and the chord-names-jazz.ly doc chart no longer includes any
alternative chord naming systems (that were already broken anyway).
- chordNamesExceptionsFull and chordNamesExceptionsPartial
properties have been removed as well (both having no longer had
any effect whatsoever for quite some time).
- the main (and now only) chordNamesExceptions property def
has been slightly updated for slightly neater glyphs and spacing,
and so as to now include power chords by default; as a result,
\powerChords is no longer needed, thereby solving any possible
confusion with \germanChords and the like. (I can’t think of any
case where users would explicitely type \chords{c:5} in order to
get the same output as \chords{c} -- can you?)
- the documentation has been updated as well; convert rules
have been added (although these may be merged with previous
2.21.0 rules once the release cycle gets back on track).
http://codereview.appspot.com/363880043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
