- Attachments has changed:
Diff:
~~~~
--- old
+++ new
@@ -0,0 +1 @@
+Screenshot of patchset4.png (68.5 kB; image/png)
~~~~
- **Needs**: -->
- **Type**: -->
- **Comment**:
Happy New Year Valentin,
Same error, look at the Rietveld upload for patch set 4. There is still no
legacy.itely file being uploaded there in your diff only legacy-code.itely. DId
you forget to git add the file or remove the offending legacy-intro.itely?
(i.e. what does git status show after you apply your own patch on clean master).
See attached png just to show you that one us isn't going mad! ;)
---
** [issues:#5449] Chord names clean-up; no more Banter, exceptionsPartial or
\powerChords.**
**Status:** Started
**Created:** Mon Dec 17, 2018 05:23 PM UTC by Valentin Villenave
**Last Updated:** Tue Jan 01, 2019 03:29 PM UTC
**Owner:** Valentin Villenave
**Attachments:**
- [Screenshot of
patchset4.png](https://sourceforge.net/p/testlilyissues/issues/5449/attachment/Screenshot%20of%20patchset4.png)
(68.5 kB; image/png)
Chord names clean-up; no more Banter, exceptionsPartial or \powerChords.
This rather large patch
- removes the legacy code for unsupported non-Ignatzek chord names;
that code hasn’t been working properly for nearly 15 years anyway, see
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00288.html
- stores a version of this code, with minor corrections, as a
self-contained snippet (for historical purposes mainly), both
on the LSR (as an upgrade to snippet #102) and in a dedicated
subsection of the Snippets doc page.
- as a result, chord-generic-names.scm is no longer found in scm/
and the chord-names-jazz.ly doc chart no longer includes any
alternative chord naming systems (that were already broken anyway).
- chordNamesExceptionsFull and chordNamesExceptionsPartial
properties have been removed as well (both having no longer had
any effect whatsoever for quite some time).
- the main (and now only) chordNamesExceptions property def
has been slightly updated for slightly neater glyphs and spacing,
and so as to now include power chords by default; as a result,
\powerChords is no longer needed, thereby solving any possible
confusion with \germanChords and the like. (I can’t think of any
case where users would explicitely type \chords{c:5} in order to
get the same output as \chords{c} -- can you?)
- the documentation has been updated as well; convert rules
have been added (although these may be merged with previous
2.21.0 rules once the release cycle gets back on track).
http://codereview.appspot.com/363880043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
