- Description has changed:

Diff:

~~~~



~~~~

- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5627] clean up the breaking of breakable Items**

**Status:** Started
**Created:** Tue Dec 03, 2019 11:30 PM UTC by Dan Eble
**Last Updated:** Wed Dec 04, 2019 03:06 PM UTC
**Owner:** Dan Eble


1: remove pointless Paper_column::do_break_processing

It did nothing but call the inherited method.  This isn't
related to the remaining changes; I just noticed it while I
was working.

2: clean up the breaking of breakable Items

* rename Grob::discretionary_processing () to the more descriptive
  break_breakable_item ()

* avoid calling break_breakable_item () on the clones that it creates

* provide the calling System to each called Item to avoid having to
  find it by walking the chain of parents

* remove an unnecessary dynamic_cast

https://codereview.appspot.com/571190043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to