- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
```text
commit afb363497684a4dd2cc2d8b10aa3de328292872c (HEAD -> staging,
origin/staging)
Author: Dan Eble <[email protected]>
Date: Fri Jun 8 16:23:21 2018 -0400
Issue 5627/2: clean up the breaking of breakable Items
...
commit 675d0db644d6efd76bd80bd7d97c56f49a8f528d
Author: Dan Eble <[email protected]>
Date: Tue Dec 3 13:27:48 2019 -0500
Issue 5627/1: remove pointless Paper_column::do_break_processing
...
```
---
** [issues:#5627] clean up the breaking of breakable Items**
**Status:** Fixed
**Labels:** Fixed_2_21_0
**Created:** Tue Dec 03, 2019 11:30 PM UTC by Dan Eble
**Last Updated:** Sat Dec 07, 2019 10:31 AM UTC
**Owner:** Dan Eble
1: remove pointless Paper_column::do_break_processing
It did nothing but call the inherited method. This isn't
related to the remaining changes; I just noticed it while I
was working.
2: clean up the breaking of breakable Items
* rename Grob::discretionary_processing () to the more descriptive
break_breakable_item ()
* avoid calling break_breakable_item () on the clones that it creates
* provide the calling System to each called Item to avoid having to
find it by walking the chain of parents
* remove an unnecessary dynamic_cast
https://codereview.appspot.com/571190043
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list._______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
