- **Comment**:

I think we need to redial or augment some of this patch since it will leave 
even experienced developers with an unexpected result.

If I now do
    GUILE_CONFIG=/usr/local/tmp/guile-1.8/bin/guile-config ./configure
on my system the slow and crash-prone Guile-2.2 will be used.  I would have 
been notified of that because the configuration would have failed because of a 
missing --with-guilev2 option, but this option is no longer necessary.  So my 
explicit choice of Guile-1.8, made in the previously supported manner, will get 
silently ignored.

That is not good.  I think that if GUILE_CONFIG is given, it should be heeded 
rather than ignored.  Also if PKG_CONFIG_PATH is given in the environment, it 
should be _recorded_ so that
./config.status --recheck
will not forget about it again.

We have dropped too many safety nets for making sure that our configure does 
what is expected of it.



---

** [issues:#5780] Accept GUILE 2 without extra configure options**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Fri Feb 21, 2020 03:18 PM UTC by Han-Wen Nienhuys
**Last Updated:** Tue Feb 25, 2020 02:43 PM UTC
**Owner:** Han-Wen Nienhuys


A run of the regression tests at "5f4cf7bd38 - Parse inline scheme
using per-expression port" shows the following issues compared to
GUILE 1.8

* changed interleaving of error and progress messages.

* floating point rounding differences.

* an encoding error in song-basic-nonenglish.ly

As of a19aed1 "GUILE2: Scale GC heap with the number of smobs",
performance for large scores with GUILE 2.2 is similar to GUILE 1.8.

For small scores, a 1.5 sec extra delay (due to byte-code compilation
of .scm files) remains, but this does not warrant the "highly
experimental" monniker.

https://codereview.appspot.com/569390043


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Testlilyissues-auto mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
  • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
    • ... Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development

Reply via email to